<html>
<head><meta charset="utf-8"><title>ping on PR #74194 (PartialEq&lt;[T]&gt; for Vec) · t-libs · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/index.html">t-libs</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/ping.20on.20PR.20.2374194.20(PartialEq.3C.5BT.5D.3E.20for.20Vec).html">ping on PR #74194 (PartialEq&lt;[T]&gt; for Vec)</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="210304036"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/ping%20on%20PR%20%2374194%20%28PartialEq%3C%5BT%5D%3E%20for%20Vec%29/near/210304036" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matt Brubeck <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/ping.20on.20PR.20.2374194.20(PartialEq.3C.5BT.5D.3E.20for.20Vec).html#210304036">(Sep 16 2020 at 18:50)</a>:</h4>
<p>Can I convince one more libs team member to sign off on FCP for <a href="https://github.com/rust-lang/rust/pull/74194">https://github.com/rust-lang/rust/pull/74194</a> ?  It's a two-line change and not really urgent, but it'd be nice not to keep rebasing and bumping it any longer.</p>



<a name="210313400"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/ping%20on%20PR%20%2374194%20%28PartialEq%3C%5BT%5D%3E%20for%20Vec%29/near/210313400" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/ping.20on.20PR.20.2374194.20(PartialEq.3C.5BT.5D.3E.20for.20Vec).html#210313400">(Sep 16 2020 at 20:05)</a>:</h4>
<p>i'm not sure how that pr wasn't tracked by us (wg-triage), will ping the remainder of people (as per what we do normally do)</p>



<a name="210314808"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/ping%20on%20PR%20%2374194%20%28PartialEq%3C%5BT%5D%3E%20for%20Vec%29/near/210314808" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matt Brubeck <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/ping.20on.20PR.20.2374194.20(PartialEq.3C.5BT.5D.3E.20for.20Vec).html#210314808">(Sep 16 2020 at 20:16)</a>:</h4>
<p>Thanks!</p>



<a name="212455651"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/ping%20on%20PR%20%2374194%20%28PartialEq%3C%5BT%5D%3E%20for%20Vec%29/near/212455651" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matt Brubeck <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/ping.20on.20PR.20.2374194.20(PartialEq.3C.5BT.5D.3E.20for.20Vec).html#212455651">(Oct 06 2020 at 16:56)</a>:</h4>
<p>Could I get an r+ on this now that FCP is complete?  Ping <span class="user-mention" data-user-id="243558">@Steven Fackler</span> because you are the assignee, or <span class="user-mention" data-user-id="118772">@Lukas Kalbertodt</span> because you looked at it initially.  Thanks again!</p>



<a name="212456149"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/ping%20on%20PR%20%2374194%20%28PartialEq%3C%5BT%5D%3E%20for%20Vec%29/near/212456149" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Steven Fackler <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/ping.20on.20PR.20.2374194.20(PartialEq.3C.5BT.5D.3E.20for.20Vec).html#212456149">(Oct 06 2020 at 17:00)</a>:</h4>
<p>did we ever do a crater run for this, or are we just going to see what the beta runs come back with?</p>



<a name="212456451"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/ping%20on%20PR%20%2374194%20%28PartialEq%3C%5BT%5D%3E%20for%20Vec%29/near/212456451" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matt Brubeck <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/ping.20on.20PR.20.2374194.20(PartialEq.3C.5BT.5D.3E.20for.20Vec).html#212456451">(Oct 06 2020 at 17:02)</a>:</h4>
<p>We did not do a crater run.  I don't know if that's something that we should do first or not.</p>



<a name="212457333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/ping%20on%20PR%20%2374194%20%28PartialEq%3C%5BT%5D%3E%20for%20Vec%29/near/212457333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matt Brubeck <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/ping.20on.20PR.20.2374194.20(PartialEq.3C.5BT.5D.3E.20for.20Vec).html#212457333">(Oct 06 2020 at 17:10)</a>:</h4>
<p>I haven't seen any example of code that could be broken by this, and failed to come up with any on my own, though that doesn't mean there is none...</p>



<a name="212457798"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/ping%20on%20PR%20%2374194%20%28PartialEq%3C%5BT%5D%3E%20for%20Vec%29/near/212457798" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matt Brubeck <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/ping.20on.20PR.20.2374194.20(PartialEq.3C.5BT.5D.3E.20for.20Vec).html#212457798">(Oct 06 2020 at 17:15)</a>:</h4>
<p>Conflicting impls aren't possible because of coherence. I don't think that ambiguous inference problems are possible, either: Any code that would use the new impls does not compile without them, as far as I can tell.</p>



<a name="212458243"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/ping%20on%20PR%20%2374194%20%28PartialEq%3C%5BT%5D%3E%20for%20Vec%29/near/212458243" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matt Brubeck <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/ping.20on.20PR.20.2374194.20(PartialEq.3C.5BT.5D.3E.20for.20Vec).html#212458243">(Oct 06 2020 at 17:18)</a>:</h4>
<p>So I guess, as author, unless I've missed something, I'm comfortable landing this without a crater run.  It can be backed out easily if any problems show up on beta, or from nightly users.</p>



<a name="212459182"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/ping%20on%20PR%20%2374194%20%28PartialEq%3C%5BT%5D%3E%20for%20Vec%29/near/212459182" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Steven Fackler <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/ping.20on.20PR.20.2374194.20(PartialEq.3C.5BT.5D.3E.20for.20Vec).html#212459182">(Oct 06 2020 at 17:27)</a>:</h4>
<p>The failure I could potentially see is something like <code>assert_eq!(vec_of_string, ["foo".into()])</code>, but we'll see how things turn out</p>



<a name="214370462"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/ping%20on%20PR%20%2374194%20%28PartialEq%3C%5BT%5D%3E%20for%20Vec%29/near/214370462" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Connor Horman <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/ping.20on.20PR.20.2374194.20(PartialEq.3C.5BT.5D.3E.20for.20Vec).html#214370462">(Oct 23 2020 at 21:57)</a>:</h4>
<p>Couldn't you impl PartialEq&lt;[UserType]&gt; for Vec&lt;UserType&gt;? Or is [UserType] not a local type (where UserType is)?</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>